Skip to content

[SPARK-10564] ThreadingSuite: assertion failures in threads don't fail the test (round 2)#8727

Closed
andrewor14 wants to merge 1 commit into
apache:masterfrom
andrewor14:fix-threading-suite
Closed

[SPARK-10564] ThreadingSuite: assertion failures in threads don't fail the test (round 2)#8727
andrewor14 wants to merge 1 commit into
apache:masterfrom
andrewor14:fix-threading-suite

Conversation

@andrewor14

@andrewor14 andrewor14 commented Sep 11, 2015

Copy link
Copy Markdown
Contributor

This is a follow-up patch to #8723. I missed one case there.

@SparkQA

SparkQA commented Sep 12, 2015

Copy link
Copy Markdown

Test build #42363 has finished for PR 8727 at commit ddc9b24.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class IntersectNode(conf: SQLConf, left: LocalNode, right: LocalNode)
    • case class SampleNode(
    • case class TakeOrderedAndProjectNode(

@andrewor14

andrewor14 commented Sep 14, 2015

Copy link
Copy Markdown
Contributor Author

retest this please

@andrewor14

andrewor14 commented Sep 14, 2015

Copy link
Copy Markdown
Contributor Author

This already passed ThreadingSuite. Merging into master.

@asfgit asfgit closed this in 7b6c856 Sep 14, 2015
asfgit pushed a commit that referenced this pull request Sep 14, 2015
[SPARK-10564] ThreadingSuite: assertion failures in threads don't fai…
5db51f9 
…l the test (round 2)

This is a follow-up patch to #8723. I missed one case there.

Author: Andrew Or <andrew@databricks.com>

Closes #8727 from andrewor14/fix-threading-suite.

(cherry picked from commit 7b6c856)
Signed-off-by: Andrew Or <andrew@databricks.com>
@SparkQA

SparkQA commented Sep 14, 2015

Copy link
Copy Markdown

Test build #42449 has finished for PR 8727 at commit ddc9b24.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14 andrewor14 deleted the fix-threading-suite branch September 15, 2015 18:10
ashangit pushed a commit to ashangit/spark that referenced this pull request Oct 19, 2016
[SPARK-10564] ThreadingSuite: assertion failures in threads don't fai…
d458e78 
…l the test (round 2)

This is a follow-up patch to apache#8723. I missed one case there.

Author: Andrew Or <andrew@databricks.com>

Closes apache#8727 from andrewor14/fix-threading-suite.

(cherry picked from commit 7b6c856)
Signed-off-by: Andrew Or <andrew@databricks.com>
(cherry picked from commit 5db51f9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andrewor14 @SparkQA